Re: [PATCH] lib/Kconfig.debug: Fix build error without CONFIG_BLOCK

From: Kees Cook
Date: Wed Apr 10 2019 - 13:31:14 EST


On Wed, Apr 10, 2019 at 12:55 AM Yue Haibing <yuehaibing@xxxxxxxxxx> wrote:
>
> From: YueHaibing <yuehaibing@xxxxxxxxxx>
>
> If CONFIG_TEST_KMOD is set to M, while CONFIG_BLOCK is not set,
> XFS and BTRFS can not be compiled successly.
>
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Fixes: d9c6a72d6fa2 ("kmod: add test driver to stress test the module loader")
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
> ---
> lib/Kconfig.debug | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 2020d76..65ad61b 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -1939,6 +1939,7 @@ config TEST_KMOD
> tristate "kmod stress tester"
> depends on m
> depends on NETDEVICES && NET_CORE && INET # for TUN
> + depends on BLOCK
> select TEST_LKM
> select XFS_FS
> select TUN

Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>

--
Kees Cook