Re: [PATCH] staging: fbtft: fix alignment should match open parenthesis

From: Dan Carpenter
Date: Wed Apr 10 2019 - 06:42:57 EST


On Wed, Apr 10, 2019 at 03:30:22PM +0530, Himadri Pandya wrote:
> Fix checkpatch warning "Alignment should match open parenthesis".
>
> Signed-off-by: Himadri Pandya <himadri18.07@xxxxxxxxx>
> ---
> drivers/staging/fbtft/fb_tinylcd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/fbtft/fb_tinylcd.c b/drivers/staging/fbtft/fb_tinylcd.c
> index 9469248f2c50..60cda57bcb33 100644
> --- a/drivers/staging/fbtft/fb_tinylcd.c
> +++ b/drivers/staging/fbtft/fb_tinylcd.c
> @@ -38,7 +38,7 @@ static int init_display(struct fbtft_par *par)
> write_reg(par, 0xE5, 0x00);
> write_reg(par, 0xF0, 0x36, 0xA5, 0x53);
> write_reg(par, 0xE0, 0x00, 0x35, 0x33, 0x00, 0x00, 0x00,
> - 0x00, 0x35, 0x33, 0x00, 0x00, 0x00);
> + 0x00, 0x35, 0x33, 0x00, 0x00, 0x00);

The original code was written that way deliberately. I don't know
why it's broken up like that but it probably means something to people
who have read the hardware spec. I would leave it as-is.

regards,
dan carpenter