Re: [LINUX PATCH v2] spi: spi-mem: Fix build error without CONFIG_SPI_MEM

From: Mark Brown
Date: Wed Apr 10 2019 - 06:31:24 EST


On Wed, Apr 10, 2019 at 11:14:45AM +0530, Naga Sureshkumar Relli wrote:
> When building with CONFIG_SPI_MEM is not set
> gc warns this:
>
> drivers/spi/spi-zynq-qspi.o: In function `zynq_qspi_supports_op':
> spi-zynq-qspi.c:(.text+0x1da): undefined reference to `spi_mem_default_supports_op'
>
> Fixes: 67dca5e580f1 ("spi: spi-mem: Add support for Zynq QSPI controller")
>
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
> Signed-off-by: Naga Sureshkumar Relli <naga.sureshkumar.relli@xxxxxxxxxx>

Why is there a signed off by for YueHaibing here? Did they write the
patch (in which case the authorship is incorrect)?

You've also got an extra blank line between the Fixes and the rest of
the tags which is unusual and might confuse some tools.

Attachment: signature.asc
Description: PGP signature