[PATCH] dns: remove redundant zero length namelen check

From: Colin King
Date: Tue Apr 09 2019 - 08:59:19 EST


From: Colin Ian King <colin.king@xxxxxxxxxxxxx>

The zero namelen check is redundant as it has already been checked
for zero at the start of the function. Remove the redundant check.

Addresses-Coverity: ("Logically Dead Code")
Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
---
net/dns_resolver/dns_query.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/net/dns_resolver/dns_query.c b/net/dns_resolver/dns_query.c
index 76338c38738a..19aa32fc1802 100644
--- a/net/dns_resolver/dns_query.c
+++ b/net/dns_resolver/dns_query.c
@@ -94,8 +94,6 @@ int dns_query(const char *type, const char *name, size_t namelen,
desclen += typelen + 1;
}

- if (!namelen)
- namelen = strnlen(name, 256);
if (namelen < 3 || namelen > 255)
return -EINVAL;
desclen += namelen + 1;
--
2.20.1