Re: [PATCH v2 3/5] media: uapi: Add RGB bus formats for the GiantPlus GPM940B0 panel

[Paul Cercueil]

Hi Thierry,

Le mer. 3 avril 2019 à 18:32, Thierry Reding 
<thierry.reding@xxxxxxxxx> a écrit :
> On Thu, Mar 14, 2019 at 01:26:20PM +0100, Paul Cercueil wrote:
> >  The GiantPlus GPM940B0 is a 24-bit TFT panel where the RGB 
> > components
> >  are transferred sequentially on a 8-bit bus.
> >
> >  Signed-off-by: Paul Cercueil <paul@xxxxxxxxxxxxxxx>
> >  ---
> >
> >  Notes:
> >      v2: New patch
> >
> >   include/uapi/linux/media-bus-format.h | 4 +++-
> >   1 file changed, 3 insertions(+), 1 deletion(-)
>
> Please make sure you Cc the media maintainers on this one when you 
> send
> the next version. Adding them now.

Oops. Will do.

> >  diff --git a/include/uapi/linux/media-bus-format.h 
> > b/include/uapi/linux/media-bus-format.h
> >  index d6a5a3bfe6c4..f31724d6cd40 100644
> >  --- a/include/uapi/linux/media-bus-format.h
> >  +++ b/include/uapi/linux/media-bus-format.h
> >  @@ -34,7 +34,7 @@
> >
> >   #define MEDIA_BUS_FMT_FIXED			0x0001
> >
> >  -/* RGB - next is	0x101b */
> >  +/* RGB - next is	0x101d */
> >   #define MEDIA_BUS_FMT_RGB444_1X12		0x1016
> >   #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE	0x1001
> >   #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE	0x1002
> >  @@ -54,6 +54,8 @@
> >   #define MEDIA_BUS_FMT_RGB888_1X24		0x100a
> >   #define MEDIA_BUS_FMT_RGB888_2X12_BE		0x100b
> >   #define MEDIA_BUS_FMT_RGB888_2X12_LE		0x100c
> >  +#define MEDIA_BUS_FMT_RGB888_3X8_BE		0x101b
> >  +#define MEDIA_BUS_FMT_RGB888_3X8_LE		0x101c
>
> The list looks roughly sorted, but these are not. That said, there are
> others that don't seem like they are sorted either.

To me it looks like it's sorted alphabetically, that's why I
put the two new macros there.

> All the more important to get feedback from the media maintainers.
>
> Thierry