Re: Regression in suspend-to-ram (TPM related) with 5.1-rc1 (BISECTED)

From: Martin Kepplinger
Date: Mon Apr 08 2019 - 05:04:34 EST


On 08.04.19 08:59, Paul Zimmerman wrote:
> On Sun, Apr 7, 2019 at 10:53 PM Martin Kepplinger
> <martin.kepplinger@xxxxxxxxxxxxx> wrote:
>>
>> On 21.03.19 14:41, Jarkko Sakkinen wrote:
>>> On Tue, Mar 19, 2019 at 04:03:37PM -0700, Paul Zimmerman wrote:
>>>> So I bisected this down to:
>>>>
>>>> # first bad commit: [a3fbfae82b4cb3ff9928e29f34c64d0507cad874] tpm:
>>>> take TPM chip power gating out of tpm_transmit()
>>>>
>>>> but this doesn't revert cleanly on Linus' HEAD. Anyone have an idea what
>>>> could be wrong here?
>>>
>>> Sorry I've been in flu for the early week. I spotted the bug
>>> immediately. When I did these patches I did not have TPM 1.x at my
>>> hand. I used fTPM 2.0 and dTPM 2.0. Stefan did TPM 1.x testing but I
>>> probably forgot to ask him to try out suspend.
>>>
>>> Anyway, the bug is obvious and I'll send you a patch to try out.
>>> Thanks a lot for bisecting this!
>>>
>>> /Jarkko
>>
>> Hi,
>>
>> Any news on this? It seems not to be fixed in -rc4. I'd happily test a
>> patch too.
>>
> Hi Martin,
> Patch is here: https://patchwork.kernel.org/patch/10865495/
> Don't know what the status of it is though.
>
> -- Paul
>

thanks. lgtm.

Tested-by: Martin Kepplinger <martink@xxxxxxxxx>

Attachment: smime.p7s
Description: S/MIME cryptographic signature