Re: [PATCH v2 07/21] x86/io: Remove useless definition of mmiowb()

From: Thomas Gleixner
Date: Fri Apr 05 2019 - 10:14:35 EST


On Fri, 5 Apr 2019, Will Deacon wrote:

> x86 maps mmiowb() to barrier(), but this is superfluous because a
> compiler barrier is already implied by spin_unlock(). Since x86 also
> includes asm-generic/io.h in its asm/io.h file, we can remove the

s/we can//

> definition entirely and pick up the dummy definition from core code.
>
> Signed-off-by: Will Deacon <will.deacon@xxxxxxx>

Reviewed-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>