Re: [PATCH v3] gcov: fix when CONFIG_MODULES is not set

From: Matthew Wilcox
Date: Wed Apr 03 2019 - 11:27:25 EST


On Tue, Apr 02, 2019 at 10:09:56AM +0700, trong@xxxxxxxxxxx wrote:
> From: Tri Vo <trong@xxxxxxxxxxx>
>
> Fixes: 8c3d220cb6b5 ("gcov: clang support")

I think this is the wrong fix. Why not simply:

+++ b/include/linux/module.h
@@ -709,6 +709,11 @@ static inline bool is_module_text_address(unsigned long addr)
return false;
}

+static inline bool within_module(unsigned long addr, const struct module *mod)
+{
+ return false;
+}
+
/* Get/put a kernel symbol (calls should be symmetric) */
#define symbol_get(x) ({ extern typeof(x) x __attribute__((weak)); &(x); })
#define symbol_put(x) do { } while (0)