Re: [GIT PULL] auxdisplay for v5.1-rc2

From: Linus Torvalds
Date: Sun Mar 24 2019 - 17:10:55 EST


On Sat, Mar 23, 2019 at 10:13 AM Miguel Ojeda
<miguel.ojeda.sandonis@xxxxxxxxx> wrote:
>
> - Series to clean up the Kconfig menus and
> a couple of improvements for charlcd.
> From Mans Rullgard

Side note: this is very annoying. As part of the rc release I'm going
through things like this, and I notice that the new Kconfig option has
absolutely no help text.

That might be acceptable if the choice of options made sense and would
be obvious to people, but they aren't obvious. Particularly not when
you come from not having an option at all, it's not at all clear that
what _used_ to happen was that "flash" option.

And yes, the Kconfig source code makes it look like there are help
texts. But a help text on the individual options for a choice isn't
actually shown when you ask for help - it's the help text for the
*choice* that matters. Not that those invisible help texts actually
_help_ anything anyway.

Linus