Re: [PATCH 11/17] x86/kprobes: Make trampoline_handler global and visible

From: Andi Kleen
Date: Sat Mar 23 2019 - 10:35:22 EST


On Sat, Mar 23, 2019 at 06:45:21PM +0900, Masami Hiramatsu wrote:
> On Thu, 21 Mar 2019 15:00:03 -0700
> Andi Kleen <andi@xxxxxxxxxxxxxx> wrote:
>
> > From: Andi Kleen <ak@xxxxxxxxxxxxxxx>
> >
> > This function is referenced from assembler, so in LTO
> > it needs to be global and visible to not be optimized away.
> >
>
> I got it.
>
> Acked-by: Masami Hiramatsu <mhiramat@xxxxxxxxxx>
>
> Andi, out of curiousity, that is not only for x86, but
> does all arch have to care it?

Yes all architectures need it for LTO, but I currently
only test x86. There are some other people who made it work
on ARM / MIPS / PowerPC before.

-Andi