Re: [PATCH v4 08/11] selftests/ftrace: Add tracing/error_log testcase

[Masami Hiramatsu]

On Fri, 22 Mar 2019 10:34:34 -0500
Tom Zanussi <zanussi@xxxxxxxxxx> wrote:

> From: Tom Zanussi <tom.zanussi@xxxxxxxxxxxxxxx>
> 
> Add a testcase verifying basic tracing/error_log functionality.

Would you be OK that you don't test all error cases with
error position?

Thank you,

> 
> Signed-off-by: Tom Zanussi <tom.zanussi@xxxxxxxxxxxxxxx>
> ---
>  .../ftrace/test.d/ftrace/tracing-error-log.tc      | 23 ++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>  create mode 100644 tools/testing/selftests/ftrace/test.d/ftrace/tracing-error-log.tc
> 
> diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/tracing-error-log.tc b/tools/testing/selftests/ftrace/test.d/ftrace/tracing-error-log.tc
> new file mode 100644
> index 000000000000..601ffebfbb9f
> --- /dev/null
> +++ b/tools/testing/selftests/ftrace/test.d/ftrace/tracing-error-log.tc
> @@ -0,0 +1,23 @@
> +#!/bin/sh
> +# SPDX-License-Identifier: GPL-2.0
> +# description: ftrace - test tracing error log support
> +
> +fail() { #msg
> +    echo $1
> +    exit_fail
> +}
> +
> +# event tracing is currently the only ftrace tracer that uses the
> +# tracing error_log, hence this check
> +if [ ! -f set_event ]; then
> +    echo "event tracing is not supported"
> +    exit_unsupported
> +fi
> +
> +echo "Test tracing error log support"
> +! echo "((sig >= 10 && sig < 15) || dsig == 17) && comm != bash" > events/signal/signal_generate/filter 2> /dev/null
> +if ! grep "error:" error_log; then
> +    fail "Failed to generate tracing error log error"
> +fi
> +
> +exit 0
> -- 
> 2.14.1
> 


-- 
Masami Hiramatsu <mhiramat@xxxxxxxxxx>