Re: [PATCH] kobject: Add support for default attribute groups to kobj_type

[Greg Kroah-Hartman]

On Fri, Mar 22, 2019 at 04:14:40PM -0400, Kimberly Brown wrote:
> kobj_type currently uses a list of individual attributes to store
> default attributes. Attribute groups are more flexible than a list of
> attributes because groups provide support for attribute visibility. So,
> add support for default attribute groups to kobj_type.
> 
> In future patches, the existing uses of kobj_typeâs attribute list will
> be converted to attribute groups. When that is complete, kobj_typeâs
> attribute list, âdefault_attrsâ, will be removed.
> 
> Signed-off-by: Kimberly Brown <kimbrownkd@xxxxxxxxx>
> ---
>  include/linux/kobject.h |  3 ++-
>  lib/kobject.c           | 14 ++++++++++++++
>  2 files changed, 16 insertions(+), 1 deletion(-)

Yes!  Thanks for doing this.

But how did you test it?  Did you convert any kobj_type structures to
the attribute group and see that all was the same?  Ideally I'd like to
take this patch with at least one subsystem that uses the change,
otherwise this looks like unused code in the kernel.

thanks,

greg k-h