Re: [PATCH v3 03/10] NTB: Introduce helper functions to calculate logical port number

From: Bjorn Helgaas
Date: Fri Mar 22 2019 - 12:51:16 EST


On Thu, Mar 21, 2019 at 06:06:38PM -0600, Logan Gunthorpe wrote:
> This patch introduces the "Logical Port Number" which is similar to the
> "Port Number" in that it enumerates the ports in the system.
>
> The original (or Physical) "Port Number" can be any number used by the
> hardware to uniquley identify a port in the system. The "Logical Port

s/uniquley/uniquely/

> Number" enumerates all ports in the system from 0 to the number of
> ports minus one.
>
> For example a system with 5 ports might have the following port numbers
> which would be enumareted thusly:

s/enumareted/enumerated/

> + * ntb_logical_port_number() - get the logical port number of the local port
> + * @ntb: NTB device context.
> + *
> + * The Logical Port Number is defined to be a unique number for each
> + * port starting from zero through to the number of ports minus one.
> + * This is in contrast to the Port Number where each port can be assigned
> + * any unqique physical number by the hardware.

s/unqique/unique/

> + * ntb_peer_logical_port_number() - get the logical peer port by given index
> + * @ntb: NTB device context.
> + * @pidx: Peer port index.
> + *
> + * The Logical Port Number is defined to be a unique number for each
> + * port starting from zero through to the number of ports minus one.
> + * This is in contrast to the Port Number where each port can be assigned
> + * any unqique physical number by the hardware.

s/unqique/unique/

Bjorn