Re: [PATCH] net: macb: Add null check for PCLK and HCLK

From: David Miller
Date: Thu Mar 21 2019 - 16:22:59 EST


From: Harini Katakam <harini.katakam@xxxxxxxxxx>
Date: Wed, 20 Mar 2019 19:12:22 +0530

> Both PCLK and HCLK are "required" clocks according to macb devicetree
> documentation. There is a chance that devm_clk_get doesn't return a
> negative error but just a NULL clock structure instead. In such a case
> the driver proceeds as usual and uses pclk value 0 to calculate MDC
> divisor which is incorrect. Hence fix the same in clock initialization.
>
> Signed-off-by: Harini Katakam <harini.katakam@xxxxxxxxxx>

Applied, thanks.