Re: [PATCH] perf arm64: Use local headers for target compiler

From: Arnaldo Carvalho de Melo
Date: Thu Mar 21 2019 - 12:39:24 EST


Em Thu, Mar 21, 2019 at 04:13:53PM +0000, Daniel Thompson escreveu:
> Currently the set of available syscalls is generated from the
> target compilers default <asm-generic/unistd.h>
> (i.e. /usr/include/asm-generic/unistd.h on a self-hosted system).

It shouldn't, Kim?

> The numeric values are then generated by the host compiler using
> tools/include/uapi/asm/unistd.h .
>
> This leads to some nasty version skew problems (including failed perf
> builds if you are running a bleeding edge distro and want to build an
> older version of perf for testing).
>
> Let's make the target compiler use the local headers too.
>
> Signed-off-by: Daniel Thompson <daniel.thompson@xxxxxxxxxx>
> ---
> tools/perf/arch/arm64/entry/syscalls/mksyscalltbl | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/perf/arch/arm64/entry/syscalls/mksyscalltbl b/tools/perf/arch/arm64/entry/syscalls/mksyscalltbl
> index c88fd32563eb..1aca6a839e4f 100755
> --- a/tools/perf/arch/arm64/entry/syscalls/mksyscalltbl
> +++ b/tools/perf/arch/arm64/entry/syscalls/mksyscalltbl
> @@ -56,7 +56,7 @@ create_table()
> echo "};"
> }
>
> -$gcc -E -dM -x c $input \
> - |sed -ne 's/^#define __NR_//p' \
> - |sort -t' ' -k2 -nu \
> +$gcc -I $incpath/include/uapi -E -dM -x c $input \
> + |sed -ne 's/^#define __NR_//p' \
> + |sort -t' ' -k2 -nu \
> |create_table
> --
> 2.20.1

--

- Arnaldo