RE: [PATCH v6] Drivers: hv: vmbus: Expose monitor data only when monitor pages are used

From: Michael Kelley
Date: Thu Mar 21 2019 - 11:55:33 EST


From: Sasha Levin <sashal@xxxxxxxxxx> Sent: Wednesday, March 20, 2019 8:57 PM
>
> I've queued it up for hyperv-fixes, thanks Kimberly.
>
> Should this go in stable as well?
>

My take: these changes lean more toward being a "clean up" rather
than fixing a problem that has significant impact. The data in the sysfs
entries is bogus, but isn't actually hurting anything. The current code does
index off the end of an array in some cases, but the accesses are reads
and there's plenty of padding so that actually making an invalid memory
reference won't happen. In the interest of reducing churn in the
stable branches, I would lean toward *not* backporting this to stable.

Michael