Re: [PATCH] drivers: ufs: Add missing MODULE_* information

From: Stanley Chu
Date: Thu Mar 21 2019 - 09:18:43 EST


Hi Anders,

On Thu, 2019-03-21 at 13:50 +0100, Anders Roxell wrote:
> When building the ufs-mediatek module the following warning shows up:
>
> WARNING: modpost: missing MODULE_LICENSE() in
> drivers/scsi/ufs/ufs-mediatek.o
>
> Rework to add MODULE_LICENSE,MODULE_AUTHOR and MODULE_DESCRIPTION.
>
> Fixes: ddd90623ce26 ("scsi: ufs-mediatek: Add UFS support for Mediatek SoC chips")
> Signed-off-by: Anders Roxell <anders.roxell@xxxxxxxxxx>
> ---
> drivers/scsi/ufs/ufs-mediatek.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c
> index c3b78fc83d3f..ce4767784937 100644
> --- a/drivers/scsi/ufs/ufs-mediatek.c
> +++ b/drivers/scsi/ufs/ufs-mediatek.c
> @@ -364,4 +364,9 @@ static struct platform_driver ufs_mtk_pltform = {
> },
> };
>
> +MODULE_AUTHOR("Stanley Chu <stanley.chu@xxxxxxxxxxxx>");
> +MODULE_AUTHOR("Peter Wang <peter.wang@xxxxxxxxxxxx>");
> +MODULE_DESCRIPTION("Mediatek UFS Driver");

Thanks for sending this.

Could you fix it as "MediaTek UFS Host Driver" ?

> +MODULE_LICENSE("GPL v2");
> +
> module_platform_driver(ufs_mtk_pltform);

Thanks,
Stanley