Re: dell_smbios KASAN bug

From: Steven Rostedt
Date: Wed Mar 20 2019 - 15:45:39 EST


On Wed, 20 Mar 2019 14:30:21 -0500
Tom Zanussi <tzanussi@xxxxxxxxx> wrote:

> > diff --git a/drivers/platform/x86/dell-smbios-base.c
> > b/drivers/platform/x86/dell-smbios-base.c
> > index 9dc282ed5a9e..c3825c674522 100644
> > --- a/drivers/platform/x86/dell-smbios-base.c
> > +++ b/drivers/platform/x86/dell-smbios-base.c
> > @@ -619,6 +619,7 @@ static int __init dell_smbios_init(void)
> >
> > fail_platform_driver:
> > kfree(da_tokens);
> > + da_num_tokens = 0;
> > return ret;
> > }
> >
>
>
> Unfortunately, no.

That's really weird. I would recommend throwing in a bunch of printks
to see if things are being freed and set, to make sure this code is hit
and something else isn't just corrupting it.

-- Steve