Re: [PATCH 1/3] mm/sparse: Clean up the obsolete code comment

From: Matthew Wilcox
Date: Wed Mar 20 2019 - 08:58:48 EST


On Wed, Mar 20, 2019 at 02:36:58PM +0200, Mike Rapoport wrote:
> There are more than a thousand -EEXIST in the kernel, I really doubt all of
> them mean "File exists" ;-)

And yet that's what the user will see if it's ever printed with perror()
or similar. We're pretty bad at choosing errnos; look how abused
ENOSPC is:

$ errno ENOSPC
ENOSPC 28 No space left on device

net/sunrpc/auth_gss/gss_rpc_xdr.c: return -ENOSPC;

... that's an authentication failure, not "I've run out of disc space".