Re: [PATCH] ath9k: Check for errors when reading SREV register

[Tom Psyborg]

On 19/03/2019, Tim Schumacher <timschumi@xxxxxx> wrote:
>
> The case in where the revision succeeded to read, but it simply
> isn't supported by the driver, is untouched and it still prints
> the original message.
>

In that case this change is fine.

> I don't know why it fails to read the SREV register in my specific
> case (I tracked it down to a WMI command timeout, which seems to
> only happen on a Raspberry Pi 3), but having the SREV error message
> (which points to the actual issue) instead of the false-positive
> "Rev not supported" message would have saved me quite some time that
> I spent with debugging the issue, searching for the source of the
> wrong value.
>

Did you try some other device than RPI3 ? I've noticed that on router
and laptop while doing some htc fw builds.