Re: [PATCH] uapi: avoid namespace conflict in linux/posix_types.h

From: David Miller
Date: Tue Mar 19 2019 - 17:46:51 EST


From: Arnd Bergmann <arnd@xxxxxxxx>
Date: Tue, 19 Mar 2019 17:51:09 +0100

> Florian Weimer points out an issue with including linux/posix_types.h
> from arbitrary other headers: if an application has defined a macro
> named 'fds_bits', it may stop compiling after a change in the kernel
> headers. Since fds_bits is a non-reserved identifier in C, that is
> considered a bug in the kernel headers.
>
> The structure definition does not really seem to be helpful here,
> as the kernel no longer provides macros to manipulate it.
...
> Fixes: a623a7a1a567 ("y2038: fix socket.h header inclusion")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Acked-by: David S. Miller <davem@xxxxxxxxxxxxx>