Re: [PATCH -next] crypto: ccp - Make ccp_register_rsa_alg static

From: Gary R Hook
Date: Tue Mar 19 2019 - 14:39:08 EST


On 3/19/19 8:50 AM, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@xxxxxxxxxx>
>
> Fix sparse warning:
>
> drivers/crypto/ccp/ccp-crypto-rsa.c:251:5:
> warning: symbol 'ccp_register_rsa_alg' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>

Acked-by: Gary R Hook <gary.hook@xxxxxxxx

> ---
> drivers/crypto/ccp/ccp-crypto-rsa.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/ccp/ccp-crypto-rsa.c b/drivers/crypto/ccp/ccp-crypto-rsa.c
> index 05850df..0b8aab00 100644
> --- a/drivers/crypto/ccp/ccp-crypto-rsa.c
> +++ b/drivers/crypto/ccp/ccp-crypto-rsa.c
> @@ -248,7 +248,8 @@ static struct ccp_rsa_def rsa_algs[] = {
> }
> };
>
> -int ccp_register_rsa_alg(struct list_head *head, const struct ccp_rsa_def *def)
> +static int ccp_register_rsa_alg(struct list_head *head,
> + const struct ccp_rsa_def *def)
> {
> struct ccp_crypto_akcipher_alg *ccp_alg;
> struct akcipher_alg *alg;
>