Re: [PATCH V2] gpio: amd-fch: Fix bogus SPDX identifier

From: Bartosz Golaszewski
Date: Tue Mar 19 2019 - 13:19:54 EST


wt., 19 mar 2019 o 15:54 Thomas Gleixner <tglx@xxxxxxxxxxxxx> napisaÅ(a):
>
> spdxcheck.py complains:
>
> include/linux/platform_data/gpio/gpio-amd-fch.h: 1:28 Invalid License ID: GPL+
>
> which is correct because GPL+ is not a valid identifier. Of course this
> could have been caught by checkpatch.pl _before_ submitting or merging the
> patch.
>
> WARNING: 'SPDX-License-Identifier: GPL+ */' is not supported in LICENSES/...
> #271: FILE: include/linux/platform_data/gpio/gpio-amd-fch.h:1:
> +/* SPDX-License-Identifier: GPL+ */
>
> Fix it under the assumption that the author meant GPL-2.0+, which makes
> sense as the corresponding C file is using that identifier.
>
> Fixes: e09d168f13f0 ("gpio: AMD G-Series PCH gpio driver")
> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> ---
> Stupid me should refresh patches before sending them. Blush!
> ---
> diff --git a/include/linux/platform_data/gpio/gpio-amd-fch.h b/include/linux/platform_data/gpio/gpio-amd-fch.h
> index a867637e172d..7290ec40a71e 100644
> --- a/include/linux/platform_data/gpio/gpio-amd-fch.h
> +++ b/include/linux/platform_data/gpio/gpio-amd-fch.h
> @@ -1,4 +1,4 @@
> -/* SPDX-License-Identifier: GPL+ */
> +/* SPDX-License-Identifier: GPL-2.0+ */
>
> /*
> * AMD FCH gpio driver platform-data
>

Patch applied.

Bart