Re: [PATCH v2 19/19] locking/lockdep: Change if to else-if when checking bfs errors

From: Bart Van Assche
Date: Tue Mar 19 2019 - 12:29:32 EST


On Mon, 2019-03-18 at 16:57 +-0800, Yuyang Du wrote:
+AD4 - if (ret +ADw 0) +AHs
+AD4 +- if (unlikely(ret +ADw 0)) +AHs
+AD4 print+AF8-bfs+AF8-bug(ret)+ADs
+AD4 return 0+ADs
+AD4 +AH0
+AD4 - if (ret +AD0APQ 1)
+AD4 +- else if (ret +AD0APQ 1)
+AD4 return ret+ADs

Have you verified this patch series with checkpatch? Checkpatch should have
reported that you are changing code that conforms to the coding style into
code that does not conform to the kernel coding style. Checkpatch should have
reported the following:

+ACI-else is not generally useful after a break or return+ACI

Thanks,

Bart.