Re: [PATCH v3] net: mlx5: Add a missing check on idr_find, free buf

From: Eric Dumazet
Date: Tue Mar 19 2019 - 12:03:19 EST




On 03/19/2019 08:55 AM, Aditya Pakki wrote:
> idr_find() can return a NULL value to 'flow' which is used without a check.
> The patch adds a check to avoid potential NULL pointer dereference.
> In case of mlx5_fpga_sbu_conn_sendmsg() failure, free buf allocated
> using kzalloc.
>
> ---
> v2: failure to return in case of flow failure.
> v1: Failed to free buf in case of flow failure.
>
> Signed-off-by: Aditya Pakki <pakki001@xxxxxxx>


Please add an appropriate Fixes: tag, thanks.