Re: [PATCH] sched: Do not re-read h_load_next during hierarchical load calculation

[Valentin Schneider]

On 19/03/2019 12:30, Mel Gorman wrote:
[...]
>>
>> Does that also want a
>>
>> Fixes: 685207963be9 ("sched: Move h_load calculation to task_h_load()")
>> Cc: stable@xxxxxxxxxxxxxxx
>>
>> ?
>>
>> Other than that, the change looks sane to me.
>>
>> Reviewed-by: Valentin Schneider <valentin.schneider@xxxxxxx>
>>
> 
> Thanks. I'll add the Fixes because it does look like the old code would
> have been ok. Thanks for the review!
> 

Well it's not worth much because I completely skipped that we *didn't*
already have a WRITE_ONCE(), which you do need as Peter mentioned. But I
do think stable will be happy to get this one :)