Re: [PATCH v5 2/3] tracing: Add trace_total_entries() / trace_total_entries_cpu()

From: Daniel Thompson
Date: Tue Mar 19 2019 - 07:30:14 EST


On Mon, Mar 18, 2019 at 05:18:46PM -0400, Steven Rostedt wrote:
> On Mon, 18 Mar 2019 13:47:40 -0700
> Douglas Anderson <dianders@xxxxxxxxxxxx> wrote:
>
> > These two new exported functions will be used in a future patch by
> > kdb_ftdump() to quickly skip all but the last few trace entries.
> >
> > Suggested-by: Steven Rostedt <rostedt@xxxxxxxxxxx>
> > Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
>
> Actually, I guess only this email needs the ack from Daniel.

I skipped this patch in v4 since I misunderstood and thought it was just
tweaking an existing trace API (which wouldn't really need an ack from
me).

I did offer a bit of feedback after reading it but TBH even if the
feedback is rejected I'm ok to ack:
Acked-by: Daniel Thompson <daniel.thompson@xxxxxxxxxx>


Daniel.