RE: [PATCH] net: stmmac: fix memory corruption with large MTUs

From: Koskinen, Aaro (Nokia - FI/Espoo)
Date: Tue Mar 19 2019 - 07:07:40 EST


Hi,

From: Jose Abreu [jose.abreu@xxxxxxxxxxxx]:
> On 3/18/2019 9:36 PM, Aaro Koskinen wrote:
> > /* Fill DES3 in case of RING mode */
> > - if (priv->dma_buf_sz >= BUF_SIZE_8KiB)
> > + if (priv->dma_buf_sz == BUF_SIZE_16KiB)
>
> Shouldn't this be: "if (priv->dma_buf_sz > BUF_SIZE_8KiB)" ?

I think it should be the same as in stmmac_init_rx_buffers():

if (priv->dma_buf_sz == BUF_SIZE_16KiB)
stmmac_init_desc3(priv, p);

A.