Re: [PATCH RESEND V6 0/5] Add i.MX7ULP EVK PWM backlight support

[Uwe Kleine-König]

On Tue, Mar 19, 2019 at 09:11:38AM +0000, Anson Huang wrote:
> Hi,
> 
> Best Regards!
> Anson Huang
> 
> > -----Original Message-----
> > From: Uwe Kleine-KÃnig [mailto:u.kleine-koenig@xxxxxxxxxxxxxx]
> > Sent: 2019å3æ19æ 16:15
> > To: Anson Huang <anson.huang@xxxxxxx>
> > Cc: thierry.reding@xxxxxxxxx; robh+dt@xxxxxxxxxx; mark.rutland@xxxxxxx;
> > shawnguo@xxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx;
> > festevam@xxxxxxxxx; linux@xxxxxxxxxxxxxxx; stefan@xxxxxxxx;
> > otavio@xxxxxxxxxxxxxxxx; Leonard Crestez <leonard.crestez@xxxxxxx>;
> > schnitzeltony@xxxxxxxxx; jan.tuerk@xxxxxxxxxxx; Robin Gong
> > <yibin.gong@xxxxxxx>; linux-pwm@xxxxxxxxxxxxxxx;
> > devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-
> > kernel@xxxxxxxxxxxxxxx; dl-linux-imx <linux-imx@xxxxxxx>
> > Subject: Re: [PATCH RESEND V6 0/5] Add i.MX7ULP EVK PWM backlight
> > support
> > 
> > On Tue, Mar 19, 2019 at 07:09:56AM +0000, Anson Huang wrote:
> > > i.MX7ULP EVK board has MIPI-DSI display, its backlight is supplied by
> > > TPM PWM module, this patch set enables i.MX7ULP TPM PWM driver
> > support
> > > and also add backlight support for MIPI-DSI display.
> > 
> > Given that you actually changed something compared to v6, this is not a
> > resend but v7. Also I suggest to practise a bit of patience before sending out
> > a new revision to prevent people still looking at the previous round. I just
> > gave feedback to the original v6 which you obviously didn't address :-|
> > 
> > Also a highlevel changelog for the series (here something like: "Properly
> > separate dt changes into soc-specific and machine-specific changes") is
> > helpful.
> 
> OK, will pay attention to that, the resend is just because the patch content is NOT
> Changed, just re-organize the DT patch.
> 
> Also, I understand that sending the patch version too quickly will result in too many
> Patch version in this thread, but I just want to address the comments ASAP when I
> Have time, hope that does NOT bother reviewer too much...

A middle way is to provide a git-tree somewhere and in reply to a review
just say: I updated the patches according to your feedback, but will
wait a bit more for further feedback before resending. If you're
interested the current work in progress can be found at git://... in the
xyz branch.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-KÃnig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |