Re: [PATCH v5 1/2] media: uapi: Add H264 low-level decoder API compound controls.

[Maxime Ripard]

On Thu, Mar 14, 2019 at 01:13:33PM +0900, Tomasz Figa wrote:
> On Thu, Mar 14, 2019 at 12:31 AM Maxime Ripard
> <maxime.ripard@xxxxxxxxxxx> wrote:
> >
> > Hi Tomasz,
> >
> > On Fri, Mar 08, 2019 at 03:12:18PM +0900, Tomasz Figa wrote:
> > > > +.. _v4l2-mpeg-h264:
> > > > +
> > > > +``V4L2_CID_MPEG_VIDEO_H264_SPS (struct)``
> > > > +    Specifies the sequence parameter set (as extracted from the
> > > > +    bitstream) for the associated H264 slice data. This includes the
> > > > +    necessary parameters for configuring a stateless hardware decoding
> > > > +    pipeline for H264.  The bitstream parameters are defined according
> > > > +    to :ref:`h264`. Unless there's a specific comment, refer to the
> > > > +    specification for the documentation of these fields, section 7.4.2.1.1
> > > > +    "Sequence Parameter Set Data Semantics".
> > >
> > > I don't see this section being added by this patch. Where does it come from?
> >
> > This is referring to the the H264 spec itself, as I was trying to
> > point out with the reference in that paragraph. How would you write
> > this down to make it more obvious?
> >
>
> Aha, somehow it didn't come to my mind when reading it. How about
> something like below?
>
> Unless there is a specific comment, refer to the ITU-T Rec. H.264
> specification, section "7.4.2.1.1 Sequence parameter set data semantics"
> (as of the 04/2017 edition).

The :ref:`h264` currently expands to "ITU H.264", which means in the
documentation, in the case above, it ends up as

 The bitstream parameters are defined according to ITU H.264. Unless
 thereâs a specific comment, refer to the specification for the
 documentation of these fields, section 7.4.2.1.1 âSequence Parameter
 Set Data Semanticsâ.

I could change the reference to have "ITU-T Rec. H.264 Specification
(04/2017 Edition)". Would that work for you?

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Attachment: signature.asc
Description: PGP signature