Re: [PATCH v2 0/5] phy: tegra: xusb: Add Tegra186 support

From: Kishon Vijay Abraham I
Date: Mon Mar 18 2019 - 04:57:09 EST


Hi Thierry,

On 21/02/19 9:16 PM, Thierry Reding wrote:
> From: Thierry Reding <treding@xxxxxxxxxx>
>
> This series adds support for Tegra186 to the XUSB pad controller driver.
> Patch 1 extends the device tree bindings with support for Tegra186 while
> patches 2-4 are preparatory work for the final patch 5 that adds the
> Tegra186 specific programming for the UPHY blocks.
>
> Changes in v2:
> - address review comments from Kishon
> - added Reviewed-by tags from JC

I've merged this series.
However I'd like to see if we can add the features of xusb.c to phy-core.c and
remove xusb.c. This will be useful if there are other PHY vendors with similar
design as Tegra.

Thanks
Kishon

>
> Thierry
>
> JC Kuo (2):
> phy: tegra: xusb: Skip single function lane programming
> phy: tegra: xusb: Add Tegra186 support
>
> Thierry Reding (3):
> dt-bindings: phy: tegra: Add Tegra186 support
> phy: tegra: xusb: Parse dual-role mode property
> phy: tegra: xusb: Add support for power supplies
>
> .../phy/nvidia,tegra124-xusb-padctl.txt | 9 +
> MAINTAINERS | 5 +
> drivers/phy/tegra/Makefile | 1 +
> drivers/phy/tegra/xusb-tegra186.c | 899 ++++++++++++++++++
> drivers/phy/tegra/xusb.c | 67 +-
> drivers/phy/tegra/xusb.h | 35 +
> 6 files changed, 1014 insertions(+), 2 deletions(-)
> create mode 100644 drivers/phy/tegra/xusb-tegra186.c
>