Re: [PATCH] IB/iser: remove uninitialized variable len

From: Max Gurtovoy
Date: Sun Mar 17 2019 - 06:05:40 EST



On 3/17/2019 1:05 AM, Colin King wrote:
From: Colin Ian King<colin.king@xxxxxxxxxxxxx>

The variable len is not being inintialized and the uninitialized
value is being returned. However, this return path is never reached
because the default case in the switch statement returns -ENOSYS.
Clean up the code by replacing the return -ENOSYS with a break
for the default case and returning -ENOSYS at the end of the
function. This allows len to be removed. Also remove redundant
break that follows a return statement.

Signed-off-by: Colin Ian King<colin.king@xxxxxxxxxxxxx>

Looks good,

Reviewed-by: Max Gurtovoy <maxg@xxxxxxxxxxxx>