Re: [GIT PULL] AFS fixes and other bits

From: Linus Torvalds
Date: Fri Mar 15 2019 - 21:49:32 EST


On Fri, Mar 15, 2019 at 4:41 PM David Howells <dhowells@xxxxxxxxxx> wrote:
>
> Here's a set of fixes and other bits for AFS to improve the life of desktop
> applications such as firefox.

I pulled, and immediately unpulled.

The thing hasn't even seen a compiler, and when you *do* show the code
to a compiler, said compiler correctly warns about
afs_do_silly_unlink() potentially returning an uninitialized variable.

And yes, it's _trivially_ and obviously uninitialized.

Feel free to submit this for 5.2 after it has actually seen testing.
But this late in the 5.1 merge window, I'm no longer interested in
totally untested new crap. It clearly wasn't ready before the merge
window, and it clearly isn't ready *now*.

Much too late to try to fix this up,

Linus