Re: [PATCH 3/3] rhashtable: rename rht_for_each*continue as *from.

From: Herbert Xu
Date: Fri Mar 15 2019 - 01:49:46 EST


On Thu, Mar 14, 2019 at 04:05:28PM +1100, NeilBrown wrote:
> The pattern set by list.h is that for_each..continue()
> iterators start at the next entry after the given one,
> while for_each..from() iterators start at the given
> entry.
>
> The rht_for_each*continue() iterators are documented as though the
> start at the 'next' entry, but actually start at the given entry,
> and they are used expecting that behaviour.
> So fix the documentation and change the names to *from for consistency
> with list.h
>
> Signed-off-by: NeilBrown <neilb@xxxxxxxx>
> ---
> .clang-format | 8 ++++----
> include/linux/rhashtable.h | 40 ++++++++++++++++++++--------------------
> lib/rhashtable.c | 2 +-
> 3 files changed, 25 insertions(+), 25 deletions(-)

Acked-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>

Thanks,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt