Re: [PATCH] ata: pata_oldpiix: Add missing device ID for INTEL_82371AB

From: LABBE Corentin
Date: Tue Mar 12 2019 - 09:38:15 EST


On Tue, Mar 12, 2019 at 12:06:23PM +0000, Alan Cox wrote:
> On Tue, 12 Mar 2019 11:41:02 +0100
> LABBE Corentin <clabbe@xxxxxxxxxxxx> wrote:
>
> > On Mon, Dec 10, 2018 at 05:52:35PM +0300, Sergei Shtylyov wrote:
> > > Hello!
> > >
> > > On 12/10/2018 04:46 PM, Corentin Labbe wrote:
> > >
> > > > When playing with a virtual SPARC machine with qemu, I found that the
> > > > IDE emulated device was not probing with the ata/pata_oldpiix driver.
> > >
> > > Correctly, it should probe with ata_piix,
> > >
> > > > But with the old ide/piix, it was probed.>
> > > > This is due to this PCI devid was not migrated from the old ide/piix.
> > >
> > > It wasn't on purpose -- the IDE driver supports the original PIIX
> > > incorrectly.
> > >
> >
> > Hello
> >
> > What about removing this old driver totally if it dont work ?
>
> If the virtual Sparc emulator is using it does that also mean actual
> Sparc hardware has it. In which case presumably it needs fixing, or at
> least moving to the generic driver assuming the firmware sets it up ?
>

The qemu works perfectly with the new Linux driver.