Re: [PATCH v2 3/3] x86/kdump/64: Change the upper limit of crashkernel reservation

From: Baoquan He
Date: Tue Mar 12 2019 - 06:12:55 EST


On 03/12/19 at 12:48pm, Kirill A. Shutemov wrote:
> > #ifdef CONFIG_X86_32
> > # define CRASH_ADDR_LOW_MAX (512 << 20)
> > # define CRASH_ADDR_HIGH_MAX (512 << 20)
> > #else
> > # define CRASH_ADDR_LOW_MAX (896UL << 20)
> > -# define CRASH_ADDR_HIGH_MAX MAXMEM
> > +# define CRASH_ADDR_HIGH_MAX (1ULL < 46)
>
> Maybe
>
> # define CRASH_ADDR_HIGH_MAX (64UL << 40)
>
> to match the notation for the rest of defines?
>
Sure, I will replace it, and repost a whole patchset with your ack added
on each patch. Thanks for your careful reviewing and great suggestions.

>
> Otherwise the patchset look good to me. You can use my ack for all of
> them:
>
> Acked-by: Kirill A. Shutemov <kirill.shutemov@xxxxxxxxxxxxxxx>
>
> > #endif
> >
> > static int __init reserve_crashkernel_low(void)
> > --
> > 2.17.2
> >
>
> --
> Kirill A. Shutemov