Re: [PATCH 18/42] drivers: gpio: lpc18xx: use devm_platform_ioremap_resource()

From: Vladimir Zapolskiy
Date: Mon Mar 11 2019 - 15:58:19 EST


On 03/11/2019 08:54 PM, Enrico Weigelt, metux IT consult wrote:
> Use the new helper that wraps the calls to platform_get_resource()
> and devm_ioremap_resource() together.
>
> Signed-off-by: Enrico Weigelt, metux IT consult <info@xxxxxxxxx>
> ---
> drivers/gpio/gpio-lpc18xx.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/gpio/gpio-lpc18xx.c b/drivers/gpio/gpio-lpc18xx.c
> index d441dba..d711ae0 100644
> --- a/drivers/gpio/gpio-lpc18xx.c
> +++ b/drivers/gpio/gpio-lpc18xx.c
> @@ -340,10 +340,7 @@ static int lpc18xx_gpio_probe(struct platform_device *pdev)
> index = of_property_match_string(dev->of_node, "reg-names", "gpio");
> if (index < 0) {
> /* To support backward compatibility take the first resource */
> - struct resource *res;
> -
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - gc->base = devm_ioremap_resource(dev, res);
> + gc->base = devm_platform_ioremap_resource(pdev, 0);
> } else {
> struct resource res;
>
>

Acked-by: Vladimir Zapolskiy <vz@xxxxxxxxx>

--
Best wishes,
Vladimir