[PATCH v2] net: renesas: fix a missing check of of_get_phy_mode

From: Kangjie Lu
Date: Mon Mar 11 2019 - 03:50:05 EST


of_get_phy_mode may fail and return a negative error code;
the fix checks the return value of of_get_phy_mode and
returns NULL of it fails.

Signed-off-by: Kangjie Lu <kjlu@xxxxxxx>
---
drivers/net/ethernet/renesas/sh_eth.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
index 339b2eae2100..239eeafe1b2d 100644
--- a/drivers/net/ethernet/renesas/sh_eth.c
+++ b/drivers/net/ethernet/renesas/sh_eth.c
@@ -3187,6 +3187,8 @@ static struct sh_eth_plat_data *sh_eth_parse_dt(struct device *dev)
return NULL;

pdata->phy_interface = of_get_phy_mode(np);
+ if (pdata->phy_interface < 0)
+ return NULL;

mac_addr = of_get_mac_address(np);
if (mac_addr)
--
2.17.1