Re: [PATCH v2 3/5] soc: qcom: socinfo: Expose custom attributes

[Marc Gonzalez]

On 21/02/2019 16:57, Bjorn Andersson wrote:

> On Thu 21 Feb 04:18 PST 2019, Laurent Pinchart wrote:
> 
>> On Wed, Feb 20, 2019 at 10:28:29AM +0530, Vaishali Thakkar wrote:
>> 
>>> The Qualcomm socinfo provides a number of additional attributes,
>>> add these to the socinfo driver and expose them via debugfs
>>> functionality.
>> 
>> What is the use case for these attributes ? I fear they will be used in
>> production systems, and that would require debugfs in production, which
>> isn't a good idea. If you need to expose those attributes for anything
>> else than debugging then we need a proper API, likely sysfs-based.
> 
> The use case of these attributes, beyond development/debugging, are
> unfortunately somewhat unknown and is the reason why they where moved to
> debugfs from the earlier attempts to upstream this.
> 
> I think the production requirements at hand prohibits debugfs to be
> present, so attributes that are required beyond development/debugging
> purposes would have to be migrated out to sysfs - but the idea here is
> that such migration would have come with the missing motivation to add
> them there today.

On a tangential note, I saw the following message when using PCIe:

atl1c 0000:01:00.0: vpd r/w failed.  This is likely a firmware bug on this device.  Contact the card vendor for a firmware update
pcilib: sysfs_read_vpd: read failed: Connection timed out

Is this in any way related to custom attributes?

Regards.