Re: [PATCH v3 9/9] ARM: configs: Add Milbeaut M10V defconfig

From: Sugaya, Taichi
Date: Wed Feb 20 2019 - 19:36:21 EST


Hi,

On 2019/02/20 22:23, Masami Hiramatsu wrote:
Hi Arnd,

2019å2æ20æ(æ) 22:18 Arnd Bergmann <arnd@xxxxxxxx>:

On Wed, Feb 20, 2019 at 2:16 PM Masami Hiramatsu
<masami.hiramatsu@xxxxxxxxxx> wrote:
2019å2æ20æ(æ) 21:28 Arnd Bergmann <arnd@xxxxxxxx>:
On Wed, Feb 20, 2019 at 12:27 PM Sugaya, Taichi
<sugaya.taichi@xxxxxxxxxxxxx> wrote:
On 2019/02/20 18:28, Arnd Bergmann wrote:
On Wed, Feb 20, 2019 at 8:44 AM Sugaya Taichi
<sugaya.taichi@xxxxxxxxxxxxx> wrote:

diff --git a/arch/arm/configs/milbeaut_m10v_defconfig b/arch/arm/configs/milbeaut_m10v_defconfig
new file mode 100644
index 0000000..a263211
--- /dev/null
+++ b/arch/arm/configs/milbeaut_m10v_defconfig
@@ -0,0 +1,175 @@

I no longer see anything here that should be turned off, but you
might want to run 'make savedefconfig' and use the output of that,
to make it easier to keep it up to date.


I got it, I use the output of 'make savedefconfig'.
One question, is that OK to add some options on it?
-Because "CONFIG_ARCH_MILBEAUT" was not listed.

What I'd do here is to apply all the patches you want to get merged in
the next few releases before running 'savedefconfig' and use the output
of that.

Let me check. Would you mean that the defconfig will include all those
drivers configs, which will not appear at this moment?

Correct.

If you already know that you will need the options, including
them now means you don't have to update the defconfig file
as much in the future.

I just concern that if other subsystem maintainer comments
on the config name. Even in that case, can we just update the
defconfig with new name?

Yes, that's easy enough.

OK, I got it :)

Thank you!


Thank you for the detail. I got it too.



Arnd