Re: [PATCH v2 5/5] base: soc: Export soc_device_register/unregister APIs

From: Vaishali Thakkar
Date: Wed Feb 20 2019 - 03:48:41 EST


On Wed, 20 Feb 2019 at 12:25, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On Wed, Feb 20, 2019 at 10:29:46AM +0530, Vaishali Thakkar wrote:
> > From: Vinod Koul <vkoul@xxxxxxxxxx>
> >
> > Qcom Socinfo driver can be built as a module, so
> > export these two APIs.
> >
> > Signed-off-by: Vinod Koul <vkoul@xxxxxxxxxx>
> > Signed-off-by: Vaishali Thakkar <vaishali.thakkar@xxxxxxxxxx>
> > ---
> > Changes since v1:
> > - None
>
> This is fixing a build breakage introduced by an earlier patch. Please
> rearange the patches so that breakage never happens.

Ok, yes. I'll put it as patch two [before adding socinfo driver].

> Also, any chance you can properly "thread" your patches so they all show
> up together? git send-email does this automatically...

I'm using send-email only but I was sending it one by one. I believe
that's the reason why didn't come as a thread. I'll fix that in next version
too.

> thanks,
>
> greg k-h