RE: [PATCH] arm64: dts: ls1028a: Add Audio DT nodes

From: Alison Wang
Date: Wed Feb 20 2019 - 03:12:51 EST


Hi, Shawn,

> On Wed, Jan 23, 2019 at 01:21:35PM +0800, Alison Wang wrote:
> > This patch adds Audio DT nodes for LS1028ARDB and LS1028AQDS boards.
> >
> > Signed-off-by: Alison Wang <alison.wang@xxxxxxx>
> > ---
> > arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts | 62
> ++++++++++++++++++++
> > arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts | 63
> +++++++++++++++++++++
> > arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 57
> +++++++++++++++++++
> > 3 files changed, 182 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> > index 14c79f4..139728e 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> > @@ -32,6 +32,49 @@
> > device_type = "memory";
> > reg = <0x0 0x80000000 0x1 0x00000000>;
> > };
> > +
> > + sys_mclk: clock-mclk {
> > + compatible = "fixed-clock";
> > + #clock-cells = <0>;
> > + clock-frequency = <25000000>;
> > + };
> > +
> > + reg_1p8v: regulator-1p8v {
> > + compatible = "regulator-fixed";
> > + regulator-name = "1P8V";
> > + regulator-min-microvolt = <1800000>;
> > + regulator-max-microvolt = <1800000>;
> > + regulator-always-on;
> > + };
> > +
> > <snip>
> > +
> > + codec: sgtl5000@a {
> > + #sound-dai-cells = <0>;
> > + compatible = "fsl,sgtl5000";
> > + reg = <0xa>;
> > + VDDA-supply = <&reg_1p8v>;
> > + VDDIO-supply = <&reg_1p8v>;
> > + clocks = <&sys_mclk>;
> > + sclk-strength = <3>;
>
> What is this property?
[Alison] It is a new property. I have submitted a patch for this new property https://lkml.org/lkml/2018/12/25/123. This patch is already merged in linux-next.

For other items you mentioned, I will modify them in v2. Thanks a lot for your review.


Best Regards,
Alison Wang