Re: [PATCH] mwifiex: don't advertise IBSS features without FW support

From: Kalle Valo
Date: Tue Feb 19 2019 - 10:16:10 EST


Brian Norris <briannorris@xxxxxxxxxxxx> wrote:

> As it is, doing something like
>
> # iw phy phy0 interface add foobar type ibss
>
> on a firmware that doesn't have ad-hoc support just yields failures of
> HostCmd_CMD_SET_BSS_MODE, which happened to return a '-1' error code
> (-EPERM? not really right...) and sometimes may even crash the firmware
> along the way.
>
> Let's parse the firmware capability flag while registering the wiphy, so
> we don't allow attempting IBSS at all, and we get a proper -EOPNOTSUPP
> from nl80211 instead.
>
> Fixes: e267e71e68ae ("mwifiex: Disable adhoc feature based on firmware capability")
> Signed-off-by: Brian Norris <briannorris@xxxxxxxxxxxx>

Patch applied to wireless-drivers-next.git, thanks.

6f21ab30469d mwifiex: don't advertise IBSS features without FW support

--
https://patchwork.kernel.org/patch/10814041/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches