Re: [PATCH net] net: stmmac: Fix a race in EEE enable callback

From: David Miller
Date: Mon Feb 18 2019 - 20:40:13 EST


From: Jose Abreu <jose.abreu@xxxxxxxxxxxx>
Date: Mon, 18 Feb 2019 14:35:03 +0100

> We are saving the status of EEE even before we try to enable it. This
> leads to a race with XMIT function that tries to arm EEE timer before we
> set it up.
>
> Fix this by only saving the EEE parameters after all operations are
> performed with success.
>
> Signed-off-by: Jose Abreu <joabreu@xxxxxxxxxxxx>
> Fixes: d765955d2ae0 ("stmmac: add the Energy Efficient Ethernet support")

Applied and queued up for -stable, thanks.