Re: [PATCH] x86: uaccess: fix regression in unsafe_get_user

From: Arthur Gautier
Date: Mon Feb 18 2019 - 16:51:59 EST


On Mon, Feb 18, 2019 at 11:15:44AM -0800, Andy Lutomirski wrote:
> This seems like it's just papering over the underlying problem: with
> Jann's new checks in place, strncpy_from_user() is simply buggy. Does
> the patch below look decent? It's only compile-tested, but it's
> conceptually straightforward. I was hoping I could get rid of the
> check-maximum-address stuff, but it's needed for architectures where
> the user range is adjacent to the kernel range (i.e. not x86_64).

I'm unable to trigger the BUG I had with my initramfs with this patch
applied. Thanks!

--
\o/ Arthur
G Gandi.net