Re: [PATCH] tcp: Namespace-ify sysctl_tcp_rmem and sysctl_tcp_wmem

[Greg KH]

On Thu, Feb 14, 2019 at 01:12:08AM +0000, Alakesh Haloi wrote:
> [ Upstream commit 356d1833b638bd465672aefeb71def3ab93fc17d ]
> 
> Note that when a new netns is created, it inherits its
> sysctl_tcp_rmem and sysctl_tcp_wmem from initial netns.
> 
> This change is needed so that we can refine TCP rcvbuf autotuning,
> to take RTT into consideration.
> 
> Signed-off-by: Eric Dumazet <edumazet@xxxxxxxxxx>
> Cc: Wei Wang <weiwan@xxxxxxxxxx>
> Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
> [alakeshh: backport to v4.14: The patch does not apply to v4.14
> directly and hence needed manual backport. Function signature for
> the function tcp_select_initial_window had to be changed to be able
> to pass pointer to struct sock.]
> Signed-off-by: Alakesh Haloi <alakeshh@xxxxxxxxxx>

Like Sasha said, why is this needed in 4.14.y?  It looks like a new
feature.  What is keeping you from just using 4.19.y if you want this
feature?

thanks,

greg k-h