Re: [PATCH][V3] regulator: axp20x: remove a redundant null check on rdev

From: Chen-Yu Tsai
Date: Mon Feb 18 2019 - 03:41:12 EST


On Fri, Feb 15, 2019 at 5:46 PM Colin King <colin.king@xxxxxxxxxxxxx> wrote:
>
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> Currently rdev is dereferenced when assigning desc before rdev is null
> checked, this is leading to static analysis warnings. However, rdev
> can never be null, so the null check is redundant and can be removed.
>
> Detected by CoverityScan, CID#1476031 ("Dereference before null check")
>
> Fixes: 77e3e3b165db ("regulator: axp20x: add software based soft_start for AXP209 LDO3")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Acked-by: Chen-Yu Tsai <wens@xxxxxxxx>