Re: [PATCH v2 2/2] drivers: devfreq: add tracing for scheduling work

From: Chanwoo Choi
Date: Mon Feb 18 2019 - 00:36:49 EST


Hi Lukasz,

On 19. 2. 15. ìí 10:05, Lukasz Luba wrote:
> This patch add basic tracing of the devfreq workqueue and delayed work.
> It aims to capture changes of the polling intervals and device state.
>
> Signed-off-by: Lukasz Luba <l.luba@xxxxxxxxxxxxxxxxxxx>
> ---
> drivers/devfreq/devfreq.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
> index 0ae3de7..660365a 100644
> --- a/drivers/devfreq/devfreq.c
> +++ b/drivers/devfreq/devfreq.c
> @@ -29,6 +29,9 @@
> #include <linux/of.h>
> #include "governor.h"
>
> +#define CREATE_TRACE_POINTS
> +#include <trace/events/devfreq.h>
> +
> static struct class *devfreq_class;
>
> /*
> @@ -394,6 +397,8 @@ static void devfreq_monitor(struct work_struct *work)
> queue_delayed_work(devfreq_wq, &devfreq->work,
> msecs_to_jiffies(devfreq->profile->polling_ms));
> mutex_unlock(&devfreq->lock);
> +
> + trace_devfreq_monitor(devfreq);
> }
>
> /**
>

Looks good to me.
Reviewed-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>

--
Best Regards,
Chanwoo Choi
Samsung Electronics