Re: [PATCH 0/2] clk: meson: Add G12A AO Clock + Reset Controller

From: Jerome Brunet
Date: Thu Feb 07 2019 - 10:11:40 EST


On Mon, 2019-02-04 at 10:13 +0100, Neil Armstrong wrote:
> This patchset add support for the Amlogic G12A SoC family Always-On
> clock and reset controller.
>
> This adds support for clocks on the Always-On domain like :
> - Always-On UARTS & I2C Controllers
> - CEC Controllers
> - SARADC source and bus clock
> - Infrared Decoder/Encoder bus clock
> - USB 32K reference clock
>
> This also adds resets lines for :
> - Always-On UARTS & I2C Controllers
> - SARADC, Infrared Decoder/Encoder
>
> This patchset depends on the ("clk: meson: rework drivers dependencies")
> from Jerome Brunet at [1].
>
> [1] https://lkml.kernel.org/r/20190201125841.26785-1-jbrunet@xxxxxxxxxxxx
>
> Neil Armstrong (2):
> dt-bindings: clk: add G12A AO Clock and Reset Bindings
> clk: meson: Add G12A AO Clock + Reset Controller
>
> .../bindings/clock/amlogic,gxbb-aoclkc.txt | 1 +
> drivers/clk/meson/Kconfig | 2 +
> drivers/clk/meson/Makefile | 2 +-
> drivers/clk/meson/g12a-aoclk.c | 448 ++++++++++++++++++
> drivers/clk/meson/g12a-aoclk.h | 15 +
> include/dt-bindings/clock/g12a-aoclkc.h | 43 ++
> include/dt-bindings/reset/g12a-aoclkc.h | 18 +
> 7 files changed, 528 insertions(+), 1 deletion(-)
> create mode 100644 drivers/clk/meson/g12a-aoclk.c
> create mode 100644 drivers/clk/meson/g12a-aoclk.h
> create mode 100644 include/dt-bindings/clock/g12a-aoclkc.h
> create mode 100644 include/dt-bindings/reset/g12a-aoclkc.h

Nothing out the ordinary, just a minor comment on the bindings.

Acked-by: Jerome Brunet <jbrunet@xxxxxxxxxxxx>