Re: [PATCH V12 3/5] i2c: tegra: Add DMA support

From: Dmitry Osipenko
Date: Wed Feb 06 2019 - 08:23:30 EST


06.02.2019 16:17, Sowjanya Komatineni ÐÐÑÐÑ:
>
>
>>>> BTW, I'm seeing "atmel_mxt_ts 0-004c: Warning: Info CRC error - device=0xF436DC file=0x000000" whithout making any modifications to the original patch as well and it shall not happen, hence there is bug somewhere. Probably FIFO triggers are still not set up correctly... ?
>>>>
>>>>
>>> In snippet you sent, I see you are forcing dma_burst to 1 always which is what set for fifo trigger levels as well and also you are forcing dma all the time.
>>> So always it will be 1 word dma burst and 1 word trigger level and that should not be an issue.
>>>
>>
>> I reverted that snippet, this log is collected with the yours original patch.
>>
> From atmel driver, looks like this warning is from maxt_update_cfg and due to CRC mismatch and above values shows read data CRC is 0Xf436dc which is compared against info_crc of all 0's
> Info_crc is based on raw config file and somehow its all 0's. this is not based on data read thru i2c.
> data->info_crc computed on data read is 0Xf436dc
>
> This warning is not related to I2C transfer
>

It doesn't happen with the I2C PIO mode. Seems it means that the I2C reads out the 0xF436DC value instead of 0x000000.. if I'm not missing anything.